Use simpler method for computing letter from number#3
Open
livecodeali wants to merge 1 commit intotravis-no-submodulefrom
Open
Use simpler method for computing letter from number#3livecodeali wants to merge 1 commit intotravis-no-submodulefrom
livecodeali wants to merge 1 commit intotravis-no-submodulefrom
Conversation
livecodeali
force-pushed
the
travis-no-submodule
branch
from
9e8e55c to
b009d0f
Compare
livecodeali
force-pushed
the
travis-no-submodule-fail
branch
from
707b510 to
440b47a
Compare
livecodeali
commented
May 10, 2019
| function fromNumber pNum | ||
| local tNum | ||
| put ((pNum - 1) mod 26) + 65 into tNum | ||
| put (pNum mod 27) + 64 into tNum |
Owner
Author
There was a problem hiding this comment.
This does not wrap around correctly. For example shifting U by 6 will cause fromNumber(27) to be called, which gives 64, (@ in ascii).
Owner
Author
|
From the test log: Notice the letters that are shifted past Z and wrap around are all out by one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a simpler method for computing the uppercase letter corresponding to a given number between 1 and 26